Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: vsphere_nas_datastore #149

Merged
merged 5 commits into from
Sep 7, 2017
Merged

New resource: vsphere_nas_datastore #149

merged 5 commits into from
Sep 7, 2017

Conversation

vancluever
Copy link
Contributor

@vancluever vancluever commented Sep 5, 2017 •
edited
Loading

This is the WIP PR for the new vsphere_nas_datastore resource.

It's nearly complete, but we need documentation and proper multiple host support. I was going to let Terraform naturally handle this, but race conditions happen if you try to create a second mount (basically a CreateNasDatastore with the exact same spec on another host) too close to the first. This can be seen in the current incarnation of the multi-host test where I have to use depends_on to chain the two resources.

The new version will just take multiple host_system_ids, which will ultimately simplify configurations and tests anyway.

Also, this PR is based on top of #142 so once that's merged I will rebase off of master instead.

@vancluever vancluever force-pushed the f-nas-datastore-resource branch 3 times, most recently from 510a81d to 1bae8b0 Compare September 6, 2017 22:37
@vancluever vancluever changed the title [WIP] New resource: vsphere_nas_datastore New resource: vsphere_nas_datastore Sep 6, 2017
@vancluever
Copy link
Contributor Author

WIP removed on this one too, now ready for review! After the vsphere_vmfs_datastore resource gets merged I will probably rebase this one on master to get rid of the irrelevant commits.

mbfrahry
mbfrahry approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wanted to confirm one thing about checking extra attributes in the tests but other than that it looks good.

vsphere/host_nas_volume_structure.go
Optional: true,
ValidateFunc: validation.StringInSlice(
[]string{
string(types.HostFileSystemVolumeFileSystemTypeNFS),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving all the constants

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

vsphere/resource_vsphere_nas_datastore_test.go
{
Config: testAccResourceVSphereNasDatastoreConfigMultiHost(),
Check: resource.ComposeTestCheckFunc(
testAccResourceVSphereNasDatastoreExists(true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like it but I'd just like to confirm that there isn't any other variable to check if it's basic/multi-host?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read picks this up reasonably well (the host ID list is updated on refresh, and if there's a mismatch the test will fail with a non-empty plan)... we could probably have a harder check, but writing the check function might be a little overly complex as we would have to derive the host IDs from the host names in the environment variables (VSPHERE_ESXI_HOST, VSPHERE_ESXI_HOST2, and VSPHERE_ESXI_HOST3). I think this should be pretty good unless there's some sort of serious edge case that comes up.

@vancluever
New resource: vsphere_nas_datastore
f134f67 
This commit introduces the vsphere_nas_datastore resource, which can be
used to manage NAS datastores via NFS v3 and v4.1.

Details in the docs. :)
@vancluever
Copy link
Contributor Author

Merging this now - thanks @mbfrahry!

@vancluever vancluever merged commit 7fb877e into master Sep 7, 2017
@vancluever vancluever deleted the f-nas-datastore-resource branch September 7, 2017 21:22
krzkowalczyk pushed a commit to krzkowalczyk/terraform-provider-vsphere that referenced this pull request Sep 8, 2017
Squashed commit of the following:
ac6c631 
commit e379e3a
Author: tf-release-bot <[email protected]>
Date:   Thu Sep 7 21:24:20 2017 +0000

    Cleanup after v0.2.2 release

commit b9f1e51
Author: tf-release-bot <[email protected]>
Date:   Thu Sep 7 21:20:50 2017 +0000

    v0.2.2

commit e243088
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:58:17 2017 -0700

    Update CHANGELOG.md

commit 7fb877e
Merge: 213762d 629376a
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:55:04 2017 -0700

    Merge pull request hashicorp#149 from terraform-providers/f-nas-datastore-resource

    New resource: vsphere_nas_datastore

commit 629376a
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:51:53 2017 -0700

    r/nas_datastore - Fix broken TF HCL

    host_system_ids needs to be supplied as a list.

commit 71c9329
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:50:24 2017 -0700

    r/nas_datastore: Wrap import section of docs properly

commit f3066d3
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:48:16 2017 -0700

    esxi2 -> esxi3 in VSPHERE_ESXI_HOST3 in devrc

commit 76b0e59
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:47:14 2017 -0700

    r/nas_datastore: Remove comment that should not be there

    Was just a misplaced start to the comment a few lines down.

commit f134f67
Author: Chris Marchesi <[email protected]>
Date:   Mon Sep 4 20:29:59 2017 -0700

    New resource: vsphere_nas_datastore

    This commit introduces the vsphere_nas_datastore resource, which can be
    used to manage NAS datastores via NFS v3 and v4.1.

    Details in the docs. :)

commit 213762d
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:34:59 2017 -0700

    Update CHANGELOG.md

commit fb3f4fb
Merge: 1eac679 2aab458
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:34:19 2017 -0700

    Merge pull request hashicorp#142 from terraform-providers/f-vmfs-datastore-resource

    New resource: vsphere_vmfs_datastore

commit 2aab458
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 20:04:45 2017 -0700

    r/vmfs_datastore: Fix import

    Smoke testing the import uncovered issues where certain fields weren't
    populated. Unfortunately populating all the fields properly and
    validating that the datastore is actually a datastore that the host has
    mounted also means that we need to know the host ID, so we have had to
    add that to the import ID.

    This has the unfortunate side effect of making it hard to test this,
    currently. I have created hashicorp/terraform#16036 to help address
    this, and will re-enable the test when it gets merged.

commit a61ebf3
Author: Chris Marchesi <[email protected]>
Date:   Wed Sep 6 12:04:42 2017 -0700

    r/vmfs_datastore: Make constants more specific, remove update state save

    The constant names were really general and we may have run into
    collisions eventually. Also, we don't need to record every disk update
    like I thought for some reason - if there is an error, it will just be
    picked up next refresh anyway. Removed this extra bit of complexity to
    be consistent with the fact that we really don't do this anywhere else.

commit fc772b4
Author: Chris Marchesi <[email protected]>
Date:   Mon Sep 4 20:45:57 2017 -0700

    r/vmfs_datastore: Fix expected folder to env var

    Was a static path before, which was causing issues with some of my tests
    because I have it set to a different path in my devrc.

commit 418b574
Author: Chris Marchesi <[email protected]>
Date:   Sat Sep 2 16:54:59 2017 -0700

    r/vmfs_datastore: Add folder support

    Just as a bonus, added folder support. This commit also ultimately
    scaffolds a lot of stuff that we will need for proper inventory support
    anyway, including helpers to determine well-known paths for the 4 major
    inventory types based off an existing managed object, which will allow
    for some saner control around where in inventory a specific item goes.
    As an example, with this approach, the vsphere_vmfs_datastore resource
    "folder" attribute can only place datastores in folders that are in the
    datacenter that the datastore is actually being set up in - so if the
    host that the datastore is being set up in is in the "dc1" datacenter,
    the folder needs to exist within "/dc1/datastore".

commit 923bab2
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 21:45:35 2017 -0700

    r/vmfs_datastore: Documentation

    Full documentation for the vsphere_vmfs_datastore resource.

commit a5b4034
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 15:40:51 2017 -0700

    r/vmfs_datastore: Add import feature

    Add an easy peasy import feature. MoRefs can be fetched via a special
    part of the vSphere web client that basically allows you to walk the
    ServiceInstance root object, which allows you to fetch datastores and a
    number of other managed object IDs.

commit c617982
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 12:39:24 2017 -0700

    r/vmfs_datastore: Fix some error strings, refine retry waiter

    Some error string cleanup, and also an update to the delete retry
    waiter so that it handles the actual ResourceInUse error instead of
    doing a string match.

commit 15c9b9a
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 11:28:37 2017 -0700

    r/vmfs_datastore: Better error messages

    Quoted most entities, and also provided better context for whole disk
    selection error messages.

commit c118a4d
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 11:17:09 2017 -0700

    r/vmfs_datastore: Support datastore renaming

    Since this resource uses MOID as the source of truth, we can support
    renaming of the datastore on this resource pretty easy. Add that
    support. This also removes the ForceNew situation if the name has
    drifted as well.

commit f4c1da1
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 10:44:19 2017 -0700

    r/vmfs_datastore: Flatten disk space denominations to MB

    Just to make things a bit more readable.

commit b2c0f0f
Author: Chris Marchesi <[email protected]>
Date:   Fri Sep 1 09:09:11 2017 -0700

    r/vmfs_datastore: Better error handling

    Moved helpers to check to see if removed datastores were missing over to
    more general and type-safe VIM fault helpers (introduced in
    vim_helper.go). This is how we will be checking for errors in the future
    - a bit of back-refactoring may need to be done later to accommodate
    this in existing code, but the path to check should be a lot more clear
    now.

commit f5e8c1c
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 23:23:43 2017 -0700

    New resource: vsphere_vmfs_datastore

    This commit introduces the vsphere_vmfs_datastore resource, which can be
    used to manage VMFS-based datastores.

    Currently only whole disk support is included, however import
    functionality is planned so that one can import existing datastores that
    don't have full-disk extents, although whole disks will only be allowed
    to be added from there.

    Support for disk expansion may also be planned, depending on business
    case.

commit 1eac679
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 22:06:16 2017 -0700

    Update CHANGELOG.md

commit 966ba86
Merge: 17c4453 b5407a9
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 22:04:25 2017 -0700

    Merge pull request hashicorp#141 from terraform-providers/f-vmfs-disks-data-source

    New data source: vsphere_vmfs_disks

commit b5407a9
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 21:59:55 2017 -0700

    New data source: vsphere_vmfs_disks

    This adds the vsphere_vmfs_disks data source, which allows someone to
    discover storage devices that can be used for VMFS datastores on a given
    ESXi host.

    The output of this is intended to be fed into a vsphere_vmfs_datastore
    resource, which allows for the creation of a VMFS datastore off a host
    or a set of hosts (ie: in the case of FC or iSCSI disks).

commit 17c4453
Author: TeamCity <[email protected]>
Date:   Thu Aug 31 23:39:37 2017 +0000

    Cleanup after v0.2.1 release

commit 2f68a47
Author: TeamCity <[email protected]>
Date:   Thu Aug 31 23:36:12 2017 +0000

    v0.2.1

commit 8a6bb57
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 16:30:53 2017 -0700

    Update CHANGELOG.md

commit c8761af
Merge: ae75db1 55de1a4
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 16:29:57 2017 -0700

    Merge pull request hashicorp#139 from terraform-providers/f-host-port-group-resource

    New resource: vsphere_host_port_group

commit 55de1a4
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 16:28:30 2017 -0700

    r/host_port_group: Add validation to vlan_id

    To ensure TF can validate the valid VLAN range.

commit ae75db1
Merge: 563f524 492e1bc
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 16:25:55 2017 -0700

    Merge pull request hashicorp#148 from terraform-providers/b-host-virtual-switch-doc-fix

    r/host_virtual_switch: Doc update for ID attribute

commit 492e1bc
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 15:03:00 2017 -0700

    r/host_virtual_switch: Doc update for ID attribute

    The ID attribute is now a composite attribute that we assemble in code,
    and not just the name of the resource, because that is not a unique
    value or very telling of where the resource is actually located.

    The ID change went in with hashicorp#138, but I forgot to update the docs.

commit 7a3c06d
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 14:53:53 2017 -0700

    New resource: vsphere_host_port_group

    This commit adds the vsphere_host_port_group resource, which can be used
    to add port groups on an ESXi host, and serves as the companion to
    vsphere_host_virtual_switch which can be used in tandem to this
    resource.

commit 563f524
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 11:28:58 2017 -0700

    Update CHANGELOG.md

commit 3d3c063
Merge: 181b638 5aaade0
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 11:27:20 2017 -0700

    Merge pull request hashicorp#138 from terraform-providers/f-host-vswitch-resource

    New resource: vsphere_host_virtual_switch

commit 5aaade0
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 11:00:08 2017 -0700

    r/host_virtual_switch: Remove unnecessary type declarations in fixtures

    These are implied by the defaults.

commit 1f40c63
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 10:36:07 2017 -0700

    r/host_virtual_switch: Break out rolling order negation

    To make it more explicit that we can't just negate the value of a
    pointer (which !obj.RollingOrder would be).

commit f5bd248
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 10:32:45 2017 -0700

    r/host_virtual_switch: Assert exactly 3 elements in ID

    SplitN should always give 3 elements on a proper ID.

commit 26ce39a
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 10:13:56 2017 -0700

    r/host_virtual_switch: Small test readability fix for missing case

    Change !expected to expected == false, to be more explicit.

commit b061d07
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 10:08:57 2017 -0700

    Make all *bool literals and assignments easier to read

    Added a small boolPtr helper function for this.

    As a TODO, I'd like to streamline helpers possibly into their own
    package, and add one for int32 which seems to be the standard int type
    in govmomi.

commit edb0836
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 21:46:08 2017 -0700

    New resource: vsphere_host_virtual_switch

    This commit adds a new resource, vsphere_host_virtual_switch, which can
    be used to manage a virtual switch on an ESXi host.

commit 181b638
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 09:02:14 2017 -0700

    Update CHANGELOG.md

commit 5ea05e1
Merge: c4e803d f06f4a8
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 31 09:00:56 2017 -0700

    Merge pull request hashicorp#146 from terraform-providers/f-host-data-source

    New data source: vsphere_host

commit c4e803d
Merge: 306b6dd 661a5df
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 23:00:49 2017 -0700

    Merge pull request hashicorp#147 from terraform-providers/vendor-tf-v0.10.3

    Vendor: Update TF to v0.10.3

commit 661a5df
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 21:49:27 2017 -0700

    Travis: Change go version used to 1.9

    So that tests work (we are using t.Helper now).

commit 64e113b
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 19:38:09 2017 -0700

    vendor: Add github.com/hashicorp/terraform/helper/validation

    We use the validators in some of the pending PR's.

commit 02e9f45
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 19:37:01 2017 -0700

    vendor: Update TF to v0.10.3

    There's some stuff some of the pending PR's here need, in particularly
    in the validation package which I will be adding shortly.

commit f06f4a8
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 14:58:54 2017 -0700

    New data source: vsphere_host

    This resource can be used to discover the managed object ID of a
    specific host. Like vsphere_datacenter, this has been written to
    facilitate the use of a managed object reference ID to fetch the host
    system object to work with various resources, such as host networking
    resources or datastores.

    Made the function name more terse as well.

commit 306b6dd
Merge: d0e15f1 10cf6a8
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 19:27:51 2017 -0700

    Merge pull request hashicorp#145 from terraform-providers/b-docs-datacenter-data-source

    d/datacenter: Re-word "default" datacenter doc references

commit 10cf6a8
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 16:21:39 2017 -0700

    d/datacenter: Re-word "default" datacenter doc references

    The "default" datacenter is actually for the most part a gvmomi thing, a
    consequence of using the DefaultDatacenter calls in the find package.
    This function simulates default datacenter fetching behaviour by
    returning a single datacenter object from inventory if, and only if, a
    singular datacenter object exists in inventory. This is always the case
    on ESXi, but not on vCenter, and if there are multiple datacenters found
    the call will fail. Docs have been updated to reflect this.

commit d0e15f1
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 15:45:22 2017 -0700

    Update CHANGELOG.md

commit 0aa17ed
Merge: 658941d d23cba6
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 15:43:32 2017 -0700

    Merge pull request hashicorp#144 from terraform-providers/f-datacenter-data-source

    New data source: vsphere_datacenter

commit d23cba6
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 15:14:53 2017 -0700

    r/datacenter: Update docs related to ESXi

    Couple of things:

    * Clarified the nature of the "default" datacenter on ESXi and how the
    name attribute has no meaning.
    * Moved all of this detail to the warning text.
    * Have decided (not 100% related to this resource) that vsphere_host
    will _require_ the vsphere_datacenter data source's output, even if
    using ESXi. The purpose of these data sources and moving to using MoRefs
    as the source of truth is to reduce ambiguity, and as such we shouldn't
    be introducing ambiguity in.

commit 03ef7d2
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 15:03:58 2017 -0700

    d/datacenter: Remove redundant datacenter_id variable

    We now just focus on the ID attribute to provide the managed object ID.

commit effd718
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 14:23:19 2017 -0700

    New data source: vsphere_datacenter

    This data source fetches the MOID for a vSphere datacenter, and is
    intended for use in other up-and-coming resources that will use a
    managed object reference to a datacenter to fetch other resources (like
    host systems), or tell resources where they need to be deployed to (may
    eventually be used in vsphere_virtual_machine, for example).

commit 701a445
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 30 13:25:31 2017 -0700

    Move getDatacenter to vsphere/datacenter_helper.go, add API handling

    Moved getDatacenter to its own helper code, as a lot of other resources
    use it. Also added the ability of it to detect the connected API type
    (ESXi vs vCenter), and just use the default if on ESXi.

commit 658941d
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 24 11:46:49 2017 -0700

    Update CHANGELOG.md

commit 730e48b
Merge: 8be9a76 17e75ce
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 24 11:45:48 2017 -0700

    Merge pull request hashicorp#79 from ewypych/p-vsphere-hostname-customization

    Set different hostname of a VM than name

commit 17e75ce
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 24 11:43:12 2017 -0700

    r/vsphere_virtual_machine: Small doc correction for hostname

    Just a small grammar fix, and also re-run the sample code through
    terraform fmt.

commit 8be9a76
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 24 11:12:34 2017 -0700

    Update CHANGELOG.md

commit 2dfd5ea
Merge: 4079169 2f58f25
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 24 11:10:25 2017 -0700

    Merge pull request hashicorp#128 from mjrider/BUGFIX-inprove-guest-ipstack-to-terraform-mapping

    Fix ip mapping from guest to terraform

commit f6f9121
Author: ewypych <[email protected]>
Date:   Tue Jun 13 21:49:12 2017 +0200

    standalone hostname during OS customization

commit 2f58f25
Author: Robbert Müller <[email protected]>
Date:   Thu Aug 24 08:39:17 2017 +0200

    Suppress differences when ip's are equal

commit 4079169
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 17:22:53 2017 -0700

    0.1.x namespace -> 0.2.x namespace

    Just to be consistent with the current release.

commit d1c0822
Merge: ccaa380 0c1af9e
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 16:39:43 2017 -0700

    Merge branch 'master' of github.com:terraform-providers/terraform-provider-vsphere

commit ccaa380
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 16:38:04 2017 -0700

    Update README to reflect required TF and current provider version

    Due to some changes in go-plugin we needed to bump the required TF
    version. Also did a vanity update to the provider example to reflect the
    latest release.

commit 0c1af9e
Author: TeamCity <[email protected]>
Date:   Wed Aug 23 23:04:55 2017 +0000

    Cleanup after v0.2.0 release

commit 7ceeaa1
Author: TeamCity <[email protected]>
Date:   Wed Aug 23 23:01:14 2017 +0000

    v0.2.0

commit 6813403
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 15:56:18 2017 -0700

    CHANGELOG: Bump version to v0.2.0

    One "breaking change" and kind of a signification that we are actively
    working on making the provider better. Felt a little wrong to leave it
    at just v0.1.x.

commit 54485e8
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 12:20:25 2017 -0700

    Update CHANGELOG.md

    Also updated formatting for resource/data source change notifications to
    match the conventions of the AWS repo.

commit f43f979
Merge: 066c9bb 283cac0
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 11:49:55 2017 -0700

    Merge pull request hashicorp#94 from ewypych/change-def-adapter

    Change default adapter_type to lsiLogic

commit 066c9bb
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 23 11:26:54 2017 -0700

    Remove deep README

    This is an old README, and the new one supersedes this one. Anything
    that was in that file that is missing in the current top-level README
    can be added later.

commit b6a3cdc
Merge: 1126e73 547f4c5
Author: Chris Marchesi <[email protected]>
Date:   Tue Aug 22 22:36:39 2017 -0700

    Merge pull request hashicorp#137 from terraform-providers/vendor-tf-v0.10.2

    vendor: Update TF to v0.10.2

commit 547f4c5
Author: Chris Marchesi <[email protected]>
Date:   Tue Aug 22 13:09:12 2017 -0700

    vendor: Update TF to v0.10.2

    In particular, we are using GetOkExists in the port group resources so
    that we can determine if inheritance is needed on certain network policy
    attributes properly - and it was renamed from GetOkRaw in v0.10.1.

commit 427c373
Author: Robbert Müller <[email protected]>
Date:   Fri Aug 18 14:57:18 2017 +0200

    Make sure we do not map v4 addresses to v6

commit 1126e73
Merge: 9f49bd4 fdb42c2
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 17:17:36 2017 -0700

    Merge branch 'master' of github.com:terraform-providers/terraform-provider-vsphere

commit 9f49bd4
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 17:15:52 2017 -0700

    Add new variables to devrc include

    To support the new DC and license resources.

commit a8b8751
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 17:15:34 2017 -0700

    Update CHANGELOG.md

commit fdb42c2
Merge: f895a87 05cdd19
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 16:58:07 2017 -0700

    Merge pull request hashicorp#110 from girishramnani/license-resource

    Enhancement: Added resource for license management

commit 05cdd19
Merge: de493e3 f895a87
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 16:51:00 2017 -0700

    Merge branch 'master' into license-resource

commit f895a87
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 16:19:21 2017 -0700

    Update CHANGELOG.md

commit dbd9b09
Merge: a1c1cb1 f337494
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 16:16:29 2017 -0700

    Merge pull request hashicorp#126 from jorgenunez/new-resource-datacenter

    Enhancement: New resource datacenter

commit f337494
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 16:11:27 2017 -0700

    Small formatting fix for test fixtures for DC resource

    Just make sure the raw string terminated on a newline and also ran the
    TF code through terraform fmt.

commit e6fbc52
Author: Robbert Müller <[email protected]>
Date:   Thu Aug 17 20:24:01 2017 +0200

    filter link local

commit a7b8195
Merge: a8fa93a a1c1cb1
Author: Robbert Müller <[email protected]>
Date:   Thu Aug 17 20:09:17 2017 +0200

    Merge remote-tracking branch 'origin/master' into BUGFIX-inprove-guest-ipstack-to-terraform-mapping

commit a1c1cb1
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 10:33:20 2017 -0700

    Update CHANGELOG.md

commit a284473
Merge: fe30565 6d23f58
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 10:03:33 2017 -0700

    Merge pull request hashicorp#129 from mjrider/networkInterfaces

    Discovery network interfaces from pci devices instead from Guest information

commit 6d23f58
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 17 09:55:58 2017 -0700

    Add test case for VM refresh panic

    This adds a test case for @mjrider's new network device polling logic
    that fixes several issues resulting from the inconsistencies between
    physical devices and IP information when the guest is shut down. The
    test is similar to the VM test, but in a second step it powers down the
    VM and does another plan. This effectively triggers the panic on the old
    code.

commit f08a7d8
Author: Robbert Müller <[email protected]>
Date:   Thu Aug 17 18:24:47 2017 +0200

    Use mvm instead of vm

commit e45fa9f
Author: Jorge Núñez <[email protected]>
Date:   Thu Aug 17 15:19:27 2017 +0200

    Fix missing ERROR messages and path to folder

commit 8f5d9a2
Author: Jorge Núñez <[email protected]>
Date:   Thu Aug 17 15:14:38 2017 +0200

    Implement second round of PR feedback (error messages, constant and path)

commit 995d9e8
Author: Robbert Müller <[email protected]>
Date:   Thu Aug 17 08:18:25 2017 +0200

    add errorhanling

commit de493e3
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 17 11:48:02 2017 +0530

    moved the error

commit e03a78e
Author: Robbert Müller <[email protected]>
Date:   Thu Aug 17 08:12:40 2017 +0200

    Code cleanup

    - added [DEBUG] tags
    - removed many log statements
    - log the right device list

commit 44a3744
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 17 10:55:35 2017 +0530

    extracted updateLabels function and changed the create license procedure for vcenter

commit 40b2a8d
Author: Jorge Núñez <[email protected]>
Date:   Wed Aug 16 14:00:02 2017 +0200

    make fmt

commit 204a4b2
Author: Jorge Núñez <[email protected]>
Date:   Wed Aug 16 13:57:01 2017 +0200

    Remove "No updates are possible" line in the documentation

commit 7932401
Author: Jorge Núñez <[email protected]>
Date:   Wed Aug 16 13:54:11 2017 +0200

    Implement PR feedback

commit f76eba8
Author: girish.ramnani <[email protected]>
Date:   Tue Aug 15 04:07:45 2017 +0530

    made the config a const

commit fe30565
Merge: 0496b01 d8e57a4
Author: Chris Marchesi <[email protected]>
Date:   Mon Aug 14 14:36:33 2017 -0700

    Merge pull request hashicorp#123 from terraform-providers/vendor-tf-0.10

    vendor: github.com/hashicorp/terraform/[email protected]

commit c46af8d
Merge: fb832ff 0496b01
Author: Robbert Müller <[email protected]>
Date:   Fri Aug 11 16:25:22 2017 +0200

    Merge branch 'master' of github.com:terraform-providers/terraform-provider-vsphere into networkInterfaces

commit a8fa93a
Author: Robbert Müller <[email protected]>
Date:   Fri Aug 11 14:17:02 2017 +0200

    Fip ip mapping from guest to terraform

    - only accept the first ip adres per family instead of the last one
      This is a problem which machines with floating ipaddresses

    - for ipv6, reject link-local ipadresses, those are auto-generated

commit d669808
Author: girish.ramnani <[email protected]>
Date:   Fri Aug 11 11:27:14 2017 +0530

    mentioned the VSPHERE_TEST_ESXI env variable in the doc

commit 316e794
Author: girish.ramnani <[email protected]>
Date:   Fri Aug 11 11:24:22 2017 +0530

    split the test into vcenter and esxi specific and removed the tabs in config

commit da02d88
Author: Jorge Núñez <[email protected]>
Date:   Fri Aug 11 02:14:12 2017 +0200

    Add documentation for new resource vsphere_datacenter

commit 31a7067
Author: Jorge Núñez <[email protected]>
Date:   Fri Aug 11 02:13:56 2017 +0200

    Add new resource vsphere_datacenter

commit 7e239a1
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 10 23:32:01 2017 +0530

    changed VCPUs to CPUs in the docs

commit 0496b01
Merge: 573de3d 2d7f7e9
Author: Chris Marchesi <[email protected]>
Date:   Thu Aug 10 09:46:15 2017 -0700

    Merge pull request hashicorp#122 from terraform-providers/f-devrc-update

    Cleanup devrc

commit d8e57a4
Author: Radek Simko <[email protected]>
Date:   Thu Aug 10 15:23:20 2017 +0200

    vendor: github.com/hashicorp/terraform/[email protected]

commit a020155
Author: Radek Simko <[email protected]>
Date:   Thu Aug 10 15:22:07 2017 +0200

    vendor: Ignore github.com/hashicorp/terraform/backend

    This is to avoid dependency sprawl - e.g. vendoring AWS or Azure SDK
    when we don't really need remote backend functionality
    in provider code - it's core's responsibility.

commit 6f712bb
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 10 12:56:08 2017 +0530

    added error and ExpectError check for ESXi server

commit 48a46cf
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 10 12:04:59 2017 +0530

    error check for invalid license instead of decode error and indentation removed

commit a638adc
Author: girish.ramnani <[email protected]>
Date:   Tue Aug 8 17:28:42 2017 +0530

    solved the wrong config and inlined the key env variable

commit 62cd62a
Author: girish.ramnani <[email protected]>
Date:   Sat Aug 5 11:09:56 2017 +0530

    updated the docs,made labels static in the test config and set labels in the read method

commit 322c3e8
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 3 16:14:16 2017 +0530

    changed labels to TypeMap and updated the readme

commit 4339e00
Author: girish.ramnani <[email protected]>
Date:   Thu Aug 3 14:13:26 2017 +0530

    add consistent spacing, removed the check for license_key

commit 3495fd2
Author: girish.ramnani <[email protected]>
Date:   Wed Aug 2 10:50:25 2017 +0530

    use different method to add license for vsphere and standalone

commit 6cfc998
Author: girish.ramnani <[email protected]>
Date:   Tue Jul 25 11:55:54 2017 +0530

    final check and cleanup

commit d0bd3c5
Author: girish.ramnani <[email protected]>
Date:   Tue Jul 25 11:17:27 2017 +0530

    updated readme

commit d69af82
Author: girish.ramnani <[email protected]>
Date:   Tue Jul 25 11:14:32 2017 +0530

    changes to merge with github master

commit d361dc8
Author: girish.ramnani <[email protected]>
Date:   Mon Jul 24 16:53:56 2017 +0530

    changed the decode method with a list->filter

commit cad35d1
Author: girish.ramnani <[email protected]>
Date:   Mon Jul 24 14:57:11 2017 +0530

    managed invalid key

commit 0a4fbfb
Author: girish.ramnani <[email protected]>
Date:   Mon Jul 24 00:52:22 2017 +0530

    renamed to test to have uppercase initials and better comments

commit 6fe8231
Author: girish.ramnani <[email protected]>
Date:   Sun Jul 23 23:59:03 2017 +0530

    changed the tags from [G] to [INFO]

commit b51f522
Author: girish.ramnani <[email protected]>
Date:   Sun Jul 23 23:51:52 2017 +0530

    removed the TODO and changed the testNames for consistency

commit 333c9e3
Author: girish.ramnani <[email protected]>
Date:   Sun Jul 23 23:28:23 2017 +0530

    changed the test messages to be more informative

commit 38f1afe
Author: girish.ramnani <[email protected]>
Date:   Sun Jul 23 23:11:16 2017 +0530

    solved the wrong file name issue

commit 9fb4f69
Author: girish.ramnani <[email protected]>
Date:   Fri Jul 21 18:53:02 2017 +0530

    added documentation for the terraform site

commit 8ec88ee
Author: girish.ramnani <[email protected]>
Date:   Tue Jul 18 11:32:01 2017 +0530

    Added integration tests

commit 7eac7c5
Author: girish.ramnani <[email protected]>
Date:   Fri Jul 14 12:54:13 2017 +0530

    added check for deleting the key

commit 7c8bf4e
Author: girish.ramnani <[email protected]>
Date:   Fri Jul 14 12:14:26 2017 +0530

    resolved the update issue

commit 7fb8093
Author: girish.ramnani <[email protected]>
Date:   Thu Jul 13 17:57:18 2017 +0530

    added license resource

commit 2d7f7e9
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 9 20:29:19 2017 -0700

    Cleanup devrc

    Correct a spelling mistake and consolidate variables. Some of these vars
    are shared between tests and annotating them to a single resource did
    not make sense. On the other hand, added annotations to reflect what the
    variables represent so that there is as little ambiguity as possible.

commit 573de3d
Merge: 7331b88 00543d3
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 9 16:31:29 2017 -0700

    Merge pull request hashicorp#121 from terraform-providers/f-devrc-and-readme

    Test environment RC file, update base and drop inner README

commit 00543d3
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 9 16:02:31 2017 -0700

    Add more detail to top-level README, remove one in vsphere/ dir

    I want the top-level README to be the source of truth here, combined
    with the documentation on the official website.

commit 882c466
Author: Chris Marchesi <[email protected]>
Date:   Wed Aug 9 15:59:50 2017 -0700

    Add environment configuration via GNUmakefile

    This adds a couple of items:

    * The ability to configure environment varaibles through
    $HOME/.tf-vsphere-devrc.mk.

    * A file, tf-vsphere-devrc.mk.example, that will contain all of the
    variables required to run the acceptance tests. The idea would be that
    someone copies the file to $HOME/.tf-vsphere-devrc.mk, and edits the
    values appropriately.

    Hoping that the list of variables will drop as the provider becomes more
    self-hosting.

commit 7331b88
Author: Chris Marchesi <[email protected]>
Date:   Tue Aug 8 22:09:14 2017 -0700

    Update CHANGELOG.md

commit aa03f7e
Merge: 256069c 1562b41
Author: Chris Marchesi <[email protected]>
Date:   Tue Aug 8 22:03:02 2017 -0700

    Merge pull request hashicorp#114 from mjrider/updatePR96

    vendor/govmomi/* - update to v0.15.0

commit fb832ff
Author: Robbert Müller <[email protected]>
Date:   Fri Jul 28 11:08:29 2017 +0200

    Added network device discovery from Virtualhardware

commit 1562b41
Author: Robbert Müller <[email protected]>
Date:   Wed Jul 26 20:24:06 2017 +0200

    update govmomi and all subpackages

commit d99d3c8
Author: Robbert Müller <[email protected]>
Date:   Wed Jul 26 20:12:29 2017 +0200

    update and cleanup vendor github.com/vmware/govmomi

commit 256069c
Author: Jake Champlin <[email protected]>
Date:   Tue Jul 25 13:23:24 2017 -0400

    Update CHANGELOG.md

commit 12a5bc8
Merge: 8653ce6 8624dab
Author: Jake Champlin <[email protected]>
Date:   Tue Jul 25 13:22:31 2017 -0400

    Merge pull request hashicorp#111 from verdel/virtual-machine-annotation

    virtual machine - add annotation argument

commit 8624dab
Author: Vadim Aleksandrov <[email protected]>
Date:   Tue Jul 25 18:10:47 2017 +0300

    virtual machine - add annotation argument

commit 8653ce6
Author: Jake Champlin <[email protected]>
Date:   Fri Jul 21 11:47:28 2017 -0400

    add missing readme

commit 6258050
Author: Aleks Saul <[email protected]>
Date:   Tue Jun 20 08:26:31 2017 -0400

    vendor/govmomi - update to v0.15.0

    Updates govmomi to v0.15.0 release

commit 283cac0
Author: ewypych <[email protected]>
Date:   Wed Jun 14 12:51:20 2017 +0200

    change default adapter_type to lsiLogic
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vancluever @mbfrahry