Fix ova deploy and tests #1221
Fix ova deploy and tests #1221
Conversation
| @@ -7178,11 +7178,17 @@ resource "vsphere_virtual_machine" "vm" { | |||
| datacenter_id = data.vsphere_datacenter.rootdc1.id | |||
| host_system_id = data.vsphere_host.roothost1.id | |||
| wait_for_guest_net_timeout = 0 | |||
| wait_for_guest_ip_timeout = 1 | |||
| wait_for_guest_ip_timeout = 0 | |||
There was a problem hiding this comment.
Why are we changing this? I'm concerned that it may surprise users depending on existing behaviour.
There was a problem hiding this comment.
Thats just to help speed up the testing. Not all ovf/ova sources have vmware tools installed, so (along with speeding things up) I didn't want to get acc test failures based on that.
There was a problem hiding this comment.
You are right, I shouldn't be reviewing code this early :)
There was a problem hiding this comment.
Ha! And I shouldn't be submitting a PR this late!
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Alloow
datastore_idto be computed since it is not required for ovf deployment, and then run VM read at the end of creation.