Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ova deployment feature #1105

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

sumitAgrawal007
Copy link
Contributor

@sumitAgrawal007 sumitAgrawal007 commented Jun 14, 2020

Description

Adding feature to deploy a VM from OVA template

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

https://gist.github.com/sumitAgrawal007/42e1f54fe6ed9a91466b1b14aa81a554

@sumitAgrawal007 sumitAgrawal007 marked this pull request as ready for review June 14, 2020 11:06
Copy link

@shylasrinivas shylasrinivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

@sumitAgrawal007
Copy link
Contributor Author

@bill-rich Hi, Can you review this.

Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm sure users will be excited for this!

@bill-rich bill-rich merged commit 9739efa into hashicorp:master Jun 22, 2020
@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants