r/virtual_machine: Ignore guest_id with content library #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aareet
approved these changes
Mar 31, 2020
Satak
reviewed
Apr 9, 2020
| @@ -1261,6 +1261,9 @@ func resourceVSphereVirtualMachineCreateClone(d *schema.ResourceData, meta inter | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // There is not currently a way to pull config values from Content Library items. If we do not send the values, | |||
| // the defaults from the template will be used. | |||
| d.Set("guest_id", "") | |||
There was a problem hiding this comment.
Could we have an IF statement before nulling this value? If user has passed guest_id it should null that out. Now this prevents any kind of customization to the VM.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.