Fix working with orphaned devices

[Fodoj]

Fixes this bug: #875

Problem is that if VM had orphaned disk saved in state file and same VM gets another orphaned disk after that, Terraform will add new disk with the same orpahed_disk_0 label. This breaks the run because label names must be unique according to virtual_machine_disk_subresource.go

The fix itself simply detects orphaned disks among already existing resources and skips them, so that they are re-added to state file as orphaned disks again, thus making this provider iterate over compelte list of orphaned disks and not only newly discovered ones.

[jetersen]

link to see current commit author: https://github.com/terraform-providers/terraform-provider-vsphere/commit/d943fe089a9ef60af52e532cb0edd0baaf9fd131.patch

@Fodoj
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

[jetersen]

Looks good to me, many thanks for taking the time to create a fix and finding the root cause.

[Fodoj]

@jetersen let me re-do the commit with proper identity

[Fodoj]

@jetersen should be fine now. :-)

[jorioux]

@Fodoj thank you so much for fixing this issue

Can someone merge this PR please ?

[bill-rich]

Looks good. Thanks for taking the time to track this down and write the fix.

[jetersen]

A release would be much appreciated :)

[pkqsun]

Hi @Fodoj

We had the same issue in #875 with Terraform v0.12.17 + terraform-provider-vsphere_v1.13.0_x4 + K8s v1.16.4, but it is occasionally.

In normal cases, I did "terraform plan -state=tfstate.xxx" cmd to refresh the infrastructure when there are additional dynamic vsphere volumes attached to the node, but the tfstate file do not change anything.

So my confuse is that with "ignore disks" in lifecycle, why and when will these orphaned disk info be saved into tfstate file?

Please check the remain logs:
https://gist.github.com/pkqsun/79e6e55c0ae6605b7762e5f960250d7

[Fodoj]

@pkqsun even though Terraform ignores changes to disks, they are still saved in the statefile, at least in this particular provider

[pkqsun]

@pkqsun even though Terraform ignores changes to disks, they are still saved in the statefile, at least in this particular provider

Thanks for your info.
After testing, terraform plan do not update tfstate file, however, terraform apply saved these dynamic vsphere volumes to tfstate file even though "Apply complete! Resources: 0 added, 0 changed, 0 destroyed. ".

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!