[doc] data source vsphere_virtual_machine for a template in a directory

[nitrocode]

Noticed that there is a folder argument for the vsphere_virtual_machine resource but not one for the equivalent data source. Instead, the name should be the full path of the template name.

This ticket is to update the documentation for this data source.

Affected Resource(s)

data source

• vsphere_virtual_machine

Terraform Configuration Files

data "vsphere_virtual_machine" "template" {
  name          = "templates/windows_server"
  datacenter_id = "${data.vsphere_datacenter.datacenter.id}"
}

[hashibot]

This issue has been open 180 days with no activity. If this issue is reproducible with the latest version of the provider and with Terraform 0.12, please comment. Otherwise this issue will be closed in 30 days.

[nitrocode]

This is still an inconsistency issue or data source feature request. I no longer have access to vsphere to test this out.

@aareet you added the documentation label to this ticket. Is the folder argument available for the data source but undocumented ?

[arizvisa]

I can consider adding this to PR #1157 which adds a number of the resource attributes to the data source, but there's no +1s at all for this. :-/

[arizvisa]

@nitrocode: So here's an opinion question (mostly because I'm new to terraform, and newish to how people use the vSphere api).

So, we get a "Parent" attribute for the vm which contains the object id that the "vsphere_virtual_machine" is contained by, and a type (which is "Folder"). So getting the path from this and exporting it as a string shouldn't be too difficult.

But if the type is actually not-a-folder, should that path still be exported you think? This should be explicitly type checked, right?

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.