Revert PR (#832) #837
Merged
Revert PR (#832) #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 832 inadvertently introduced issues when the token policy did not have the required permissions to read the root configuration. This reverts commit f8b83fb.
ghost
added
the
kalafut
approved these changes
Jul 31, 2020
jasonodonnell
approved these changes
Jul 31, 2020
|
@catsby Even with correct permissions, the problem also exists when a region is not provided in root configuration. For example, for those that are using the assumed_role configuration |
|
Hey @BonzTM - could you possibly share an example configuration that demonstrates what issue you're having? I'm trying to survey the types of issues present here, specifically in v2.12.0 or v2.12.2 |
|
@catsby I'm sorry, I believe I was just echoing the comment in the open issue at the time. v2.12.0 and v2.12.2 are fine. v2.12.1 has issues when a region is not specified in the core config. Such configurations exist when leveraging the assumed_role configuration of the auth method. |
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
PR 832 inadvertently introduced issues when the token policy did not have the required permissions to read the root configuration. This reverts commit f8b83fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 832 inadvertently introduced issues when the token policy did not
have the required permissions to read the root configuration.
This reverts commit f8b83fb.
Fixes #833