Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tls_ca and tls_certificate_key for mongodb connections #822

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cyrus-mc
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Add TLS options to MongoDB database connection to allow verification of certificate as well as client auth. This is in line with the CLI options .


Add `tls_ca` and `tls_certificate_key` fields to `vault_database_secret_backend_connection` for `mongodb` connections. 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

- WIP
...

@ghost ghost added the size/S label Jul 19, 2020
@ghost ghost added size/M documentation and removed size/S labels Jul 19, 2020
@martinssipenko
Copy link
Contributor

Is this PR dead or alive? I'd like to add similar functionality for MySQL, given Vault 1.5.0 supports mTLS for MySQL hashicorp/vault#9181 now.

If it's not being worked on we'd like to take this as a base, add MySQL stuff and fix tests.

cc @cyrus-mc

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@benashz
Copy link
Contributor

benashz commented May 4, 2022

Closed with #1146

@benashz benashz closed this May 4, 2022
@benashz benashz reopened this May 4, 2022
@fairclothjm
Copy link
Contributor

@cyrus-mc Hi, are you still interested in carrying this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants