If secret has been deleted from vault, drop it from the state.

[tomwilkie]

I cribbed this from https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_ami.go#L151, might not be the right way of signalling the resource has been deleted.

Fixes #55

[apparentlymart]

Hi @tomwilkie! Thanks for working on this.

This is indeed the current way to signal to Terraform that the object referenced by a resource has been deleted. Along with this, we usually like to have a debug log explaining what's happened here, in case this happens erroneously in a case where returning an error would be more appropriate and we consult the logs to figure out why. (aws_ami is, unfortunately, not a good example here. 😖)

    log.Printf("vault_generic_secret at %s has been deleted, so removing it from state", path)

[tomwilkie]

Thanks for the review @apparentlymart - I've add the log line.

[adamdecaf]

LGTM. We ran into this and I had the same patch. Could we get this deployed?

A quick glance at the issues almost looks like there are many reports of this: #1, #50, #55, #58

[paddycarver]

I'm happy to merge this, but ideally I'd like to see an acceptance test that would catch this behaviour. I'll put a reminder to follow up on this again at the end of the week, and I'll write the test myself and find a reviewer if nobody has had the time to get to it by then.

[paultyng]

@tomwilkie sorry I missed this when I just wrote up #83, but it should be covered now with the fix and an acceptance test.

[paddycarver]

Hey @tomwilkie, just wanted to echo @paultyng here: thanks so much for contributing to Terraform, and my apologies for not picking this one up in a timelier manner. And then it slipped my mind this morning while reviewing #83. Really do appreciate your time and effort here, and my sincerest apologies for the oversight.