Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PKI Config URLs Update #512

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix PKI Config URLs Update #512

merged 1 commit into from
Sep 3, 2019

Conversation

sl1pm4t
Copy link

@sl1pm4t sl1pm4t commented Aug 24, 2019

Fixes an issue with the provider is forming an invalid URL used for updating vault_pki_secret_backend_config_urls resources:

Error: Error applying plan:

1 error(s) occurred:

* vault_pki_secret_backend_config_urls.config_urls: 1 error(s) occurred:

* vault_pki_secret_backend_config_urls.config_urls: error updating URL config for PKI secret backend "pki/config/urls": Error making API request.

URL: PUT https://localhost:8200/v1/pki/config/urls/config/urls
Code: 404. Errors:

* 1 error occurred:
	* unsupported path

Fixes #430

@ghost ghost added the size/XS label Aug 24, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Sep 3, 2019
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 1615fff into hashicorp:master Sep 3, 2019
@sl1pm4t
Copy link
Author

sl1pm4t commented Sep 3, 2019

Thanks @tyrannosaurus-becks - also has to be said that's the best handle ever!

@sl1pm4t sl1pm4t deleted the fix-pki-urls-update branch September 3, 2019 23:14
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@tyrannosaurus-becks
Merge pull request hashicorp#512 from sl1pm4t/fix-pki-urls-update
05925da 
Fix PKI Config URLs Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vault_pki_secret_backend_config_urls update and read malformed URL
2 participants
@sl1pm4t @tyrannosaurus-becks