Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with updating fields for several resources #318

Merged
merged 4 commits into from
Mar 5, 2019

Conversation

lawliet89
Copy link
Contributor

@lawliet89 lawliet89 commented Feb 22, 2019

This is a follow up to several PRs I made recently:

Fix incorrect field updating in gcp_auth_backend_role

I made a mistake in setting the new TypeBool fields.

GetOk will return whether or not the key has been set to a non-zero value at some point as the second value. If the value is false, the second parameter will be false. Thus if a field was changed from true to false, this will never be caught.

Fix d.Set

When using d.Set on aggregate types, they can potentially fail. See Terraform docs.

I've updated some resources to check for these:

  • gcp_auth_backend_role
  • kubernetes_auth_backend_role
  • identity_group

@ghost ghost added the size/XS label Feb 22, 2019
@lawliet89 lawliet89 changed the title Fix incorrect field updating in gcp_auth_backend_role Fix some issues with updating fields for several resources Feb 25, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lawliet89!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 17e897f into hashicorp:master Mar 5, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Fix some issues with updating fields for several resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants