Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update all secrets mount resources with API fields #2332

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update all secrets mount resources with API fields #2332

wants to merge 3 commits into from

Conversation

vinay-gopalan
Copy link
Contributor

Description

Updates all Secrets Mount resources to include all vault_mount fields.

Relates OR Closes #2223 #1051

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ === RUN   TestAccAWSSecretBackendRole_MountConfig
    resource_aws_secret_backend_test.go:178: Vault server version "1.19.0-beta1+ent"
--- PASS: TestAccAWSSecretBackendRole_MountConfig (1.25s)
PASS


$ === RUN   TestAccAzureSecretBackend_MountConfig
    resource_azure_secret_backend_test.go:157: Vault server version "1.19.0-beta1+ent"
--- PASS: TestAccAzureSecretBackend_MountConfig (1.18s)
PASS

fairclothjm
fairclothjm reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vinay! Looking good so far! Do you know if there are any policy changes required for this update?

vault/resource_ad_secret_backend.go
"github.com/hashicorp/terraform-provider-vault/util/mountutil"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/vault/api"
)

func adSecretBackendResource() *schema.Resource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the AD resources are deprecated, I wonder if we should not update this? There is no harm in it, per se. But I don't think we want to give the wrong idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have they officially been deprecated? I thought we had previously decided to delay the deprecation because users were having trouble migrating over to OpenLDAP, but the decision may have changed since then, so please let me know if I'm not up to date 🙏🏼

Copy link
Contributor

@fairclothjm fairclothjm Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of support for AD secrets is this quarter and removal is the begging of next year.

https://developer.hashicorp.com/vault/docs/deprecation#active-directory-secrets-engine

vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
vault/resource_aws_secret_backend.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: vault_azure_secret_backend support listing_visibility attribute
2 participants
@vinay-gopalan @fairclothjm