Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add use_private_ip and add to test #2287

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KyriosGN0
Copy link

@KyriosGN0 KyriosGN0 commented Jun 29, 2024

Description

This PR adds the ability to create a database connection resource to cloudSQL (postgres) with privateIP

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@KyriosGN0 KyriosGN0 force-pushed the feat/add-support-for-privateip-in-cloudsql branch from 3e45436 to 06ccef5 Compare October 17, 2024 13:58
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
@KyriosGN0 KyriosGN0 marked this pull request as ready for review October 17, 2024 14:09
@KyriosGN0 KyriosGN0 marked this pull request as draft November 10, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant