Add Azure Auth WIF fields #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zlaticanin
commented
Jun 6, 2024
| callTune = true | ||
| } | ||
|
|
||
| if callTune { | ||
| if err := tuneMount(client, "auth/"+path, input); err != nil { | ||
| return err | ||
| if err := tuneMount(client, "auth/"+path, config); err != nil { |
There was a problem hiding this comment.
Similar to GCP, we should update this to pass in the context. I can update these in the follow up PR if that works with folks.
vinay-gopalan
requested changes
Jun 6, 2024
There was a problem hiding this comment.
The Azure Auth WIF test is failing locally due to missing (resource) and unsupported (subscription_id) parameters. I believe this patch should get us to the desired state
azureauth.patch
Thank you! I updated the PR with suggestions and ran the tests and they should be all passing locally. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.