Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add use_annotations_as_alias_metadata field to auth_kubernetes_config #2213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c0deaddict
Copy link

@c0deaddict c0deaddict commented Mar 27, 2024

Description

This PR adds the field use_annotations_as_alias_metadata to the vault_kubernetes_auth_backend_config resource. The field is missing in older versions of Vault (<1.16) so it's made optional in the code.

Closes #2224

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

^ I'm not sure how to run the acceptance tests locally, kind of hoping they run on CI?

I have tested the binary generated with make build locally against Vault 1.16.1.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add use_annotations_as_alias_metadata to the vault_kubernetes_auth_backend_config
2 participants