Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approle: handle 404 on state refresh #2204

Merged
merged 3 commits into from
Mar 25, 2024
Merged

approle: handle 404 on state refresh #2204

merged 3 commits into from
Mar 25, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Mar 21, 2024 •
edited
Loading

Description

This should tell TF to remove the entry from state and prevent an error when the approle secret ID has expired.

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@vinay-gopalan vinay-gopalan self-requested a review March 21, 2024 18:12
@fairclothjm fairclothjm added this to the 4.2.0 milestone Mar 25, 2024
@fairclothjm fairclothjm merged commit cd36775 into main Mar 25, 2024
12 checks passed
@fairclothjm fairclothjm deleted the approle/handle-404 branch March 25, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fairclothjm @vinay-gopalan