-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resources vault_plugin
and vault_plugin_pinned_version
#2159
Conversation
vault_plugin
and vault_plugin_pinned_version
Sorry - the tests are taking a bit longer than I expected. I'm working on them in https://github.com/hashicorp/terraform-provider-vault/compare/vault-24407/plugin-and-pinned-versions-support-testing?expand=1 but feel free to ignore this PR until I get them working. |
The tests should pass now 👍 and I've verified that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. My only question is should we be checking for the resource existence and unsetting the id to remove it from TF state for both vault_plugin_pinned_version and vault_plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Had a couple of questions/suggestions :)
Co-authored-by: vinay-gopalan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and responding to feedback! LGTM, had a few nits and suggestions fixes for docs sidebars, but should be good to go otherwise 😄
Co-authored-by: vinay-gopalan <[email protected]>
Co-authored-by: vinay-gopalan <[email protected]>
Co-authored-by: vinay-gopalan <[email protected]>
Thanks! |
Description
Adds 2 new resources for managing external plugins;
vault_plugin
andvault_plugin_pinned_version
.Relates #1975
Closes #214
Checklist
Output from acceptance testing:
Example config:
Community Note