Add acceptance tests for the password policy framework implementation #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
approved these changes
Dec 18, 2023
Comment on lines
+17
to
+20
| // Ideally this struct would be imbedded into all Resources and DataSources. | ||
| // However, the Terraform Plugin Framework doesn't support unmarshalling nested | ||
| // structs. See https://github.com/hashicorp/terraform-plugin-framework/issues/242 | ||
| // So for now, we must duplicate all fields. |
There was a problem hiding this comment.
Thanks for the context here.
| @@ -1,52 +0,0 @@ | |||
| // Copyright (c) HashiCorp, Inc. | |||
There was a problem hiding this comment.
I think you can also delete vault/password_policy.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
idfield to the base schema becauseidattribute was implicitly added in the sdkV2 so we must explicitly add it for existing resources, otherwise its a breaking change for practitioners andidfield to state for the Create/Update/Delete operations which is required for backwards compat and acceptance testingAdditionally, we add a placeholder directory structure for new resources and datasources implemented with the TF Plugin Framework: