Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvv2: make path/mount regex lazy eval #2104

Merged
merged 2 commits into from
Dec 4, 2023
Merged

kvv2: make path/mount regex lazy eval #2104

merged 2 commits into from
Dec 4, 2023

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Dec 4, 2023 •
edited
Loading

Description

Relates OR Closes #2103

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@github-actions github-actions bot added the size/S label Dec 4, 2023
@fairclothjm fairclothjm requested a review from a team December 4, 2023 16:20
@fairclothjm fairclothjm added this to the 3.24.0 milestone Dec 4, 2023
austingebauer
austingebauer approved these changes Dec 4, 2023
View reviewed changes
vault/resource_kv_secret_v2_test.go
@@ -22,6 +22,49 @@ var testKVV2Data = map[string]interface{}{
"baz": "qux",
}

func TestAccKVSecretV2_pathRegex(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fairclothjm fairclothjm merged commit ffdba17 into main Dec 4, 2023
2 checks passed
@fairclothjm fairclothjm deleted the VAULT-22440/kvv2-regex-lazy branch December 4, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingebauer austingebauer austingebauer approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
3.24.0
Development

Successfully merging this pull request may close these issues.

vault_kv_secret_v2 perpetual diff when the word "data" is in secret name/path
2 participants
@fairclothjm @austingebauer