Bring the Vault provider to gcp sql parity with Vault #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zlaticanin
reviewed
Sep 28, 2023
| @@ -752,6 +754,20 @@ func connectionStringResource(config *connectionStringConfig) *schema.Resource { | |||
| } | |||
| } | |||
|
|
|||
| if config.isCloud { | |||
| res.Schema["auth_type"] = &schema.Schema{ | |||
There was a problem hiding this comment.
Small nit, but should we maybe use constants for these fields? We can add them to the internal/consts.go where we keep most of them?
There was a problem hiding this comment.
I think we could - it didn't match with the rest of the file so i didn't commit.
fairclothjm
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
LGTM, can we rebase this against main once #2035 is merged?
fairclothjm
reviewed
Oct 2, 2023
kpcraig
commented
Oct 2, 2023
vinay-gopalan
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the two fields for mysql and postgres databases that were added in vault 1.15 to allow Vault to use GCP IAM roles to access databases.
The change on vault added two fields, "auth_type", for which the currently only valid values is "gcp_iam", and "service_account_json", for supplying a specific json encoding of an access token.