Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTP transport wrapper to support TLSConfig cloning #1926

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Update HTTP transport wrapper to support TLSConfig cloning #1926

merged 5 commits into from
Jul 11, 2023

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 7, 2023 •
edited
Loading

Fixes #1916

@benashz benashz added this to the 3.18.0 milestone Jul 7, 2023
@fairclothjm fairclothjm self-assigned this Jul 10, 2023
@benashz benashz self-assigned this Jul 10, 2023
@vinay-gopalan vinay-gopalan self-assigned this Jul 10, 2023
vinay-gopalan
vinay-gopalan approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Had a couple comments/questions :)

testutil/testutil.go Outdated Show resolved Hide resolved
internal/provider/auth_azure_test.go Show resolved Hide resolved
internal/provider/auth_cert_test.go Show resolved Hide resolved
@benashz benashz merged commit a29d79b into main Jul 11, 2023
@benashz benashz deleted the VAULT-17443/fix-panic-in-auth_login_cert branch July 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@fairclothjm fairclothjm Awaiting requested review from fairclothjm

Assignees

@fairclothjm fairclothjm

@benashz benashz

@vinay-gopalan vinay-gopalan

Labels
dependencies size/XL
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

Setting auth_login_cert causes a panic with v3.17.0+
3 participants
@benashz @vinay-gopalan @fairclothjm