Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil check for IsEnterpriseSupported util #1787

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add nil check for IsEnterpriseSupported util #1787

merged 1 commit into from
Mar 7, 2023
+11 −0

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Mar 6, 2023 •
edited
Loading

This PR adds a nil check that was missed while adding the IsEnterpriseSupported util function. The Vault Version can be nil if skip_get_vault_version is set as true in the provider block.

Fixes #1784

This PR also adds a test case that tests this use-case.

@vinay-gopalan vinay-gopalan requested a review from a team March 6, 2023 22:40
@vinay-gopalan vinay-gopalan added this to the 3.13.1 milestone Mar 6, 2023
@vinay-gopalan vinay-gopalan merged commit 5da8a77 into main Mar 7, 2023
@vinay-gopalan vinay-gopalan deleted the fix/is-enterprise-nil-check branch March 7, 2023 00:02
@vinay-gopalan vinay-gopalan mentioned this pull request Mar 7, 2023
Closed
@vinay-gopalan vinay-gopalan modified the milestones: 3.13.1, 3.14.0 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymonstah raymonstah raymonstah approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

3.13.0: panic: IsEnterpriseSupported
2 participants
@vinay-gopalan @raymonstah