Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set VAULT_AUTH_CONFIG_GITHUB_TOKEN on vault container to avoid GH rate limit when running acceptance tests #1763

Conversation

raymonstah
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestAccXXX -timeout 30m ./...
?       github.com/hashicorp/terraform-provider-vault   [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/coverage      [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/generate      [no test files]
?       github.com/hashicorp/terraform-provider-vault/generated [no test files]
ok      github.com/hashicorp/terraform-provider-vault/codegen   0.677s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode    0.385s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode    0.578s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet    0.788s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role        1.217s [no tests to run]
?       github.com/hashicorp/terraform-provider-vault/helper    [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/consts   [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/identity/group   [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/pki      [no test files]
?       github.com/hashicorp/terraform-provider-vault/internal/identity/mfa     [no test files]
?       github.com/hashicorp/terraform-provider-vault/schema    [no test files]
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template    0.910s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation      0.401s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/internal/identity/entity  0.510s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/internal/provider 0.728s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/testutil  0.804s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/util      0.906s [no tests to run]
ok      github.com/hashicorp/terraform-provider-vault/vault     0.616s [no tests to run]

@raymonstah
Copy link
Contributor Author

Note the acceptance tests will still fail since the vault versions are pinned. See hashicorp/vault#19244 for the fix

@raymonstah raymonstah marked this pull request as ready for review February 21, 2023 17:14
@raymonstah raymonstah changed the title set VAULT_AUTH_GITHUB_TOKEN on vault container to avoid GH rate limit when running acceptance tests set VAULT_AUTH_CONFIG_GITHUB_TOKEN on vault container to avoid GH rate limit when running acceptance tests Feb 21, 2023
@raymonstah raymonstah merged commit 150bfd1 into main Feb 21, 2023
@raymonstah raymonstah deleted the VAULT-13616-auth-github-use-github-token-env-variable-for-requests-if-it-is-set branch February 21, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants