Ensure that the qr_size can be properly configured. #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the identity_mfa_totp resource's schema did not allow the qr_size field to be configured by the user. It was set as Computed, but not Optional. After resolving this issue we discovered that Create/Update functions would always include this param in the vault API request, which negated the benefits of the field being Computed. In order to resolve the above issue above, and other similar ones, it is now possible to set the VaultAPIGetterFunc by field on the contextFuncConfig. Which means it is possible to use any of the following schema.ResourceData methods: GetOk(), Get(), GetOkExists()
vinay-gopalan
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
identity_mfa_totpresource's schema did not allow theqr_sizefield to be configured by the user. It was set as Computed, but not Optional. After resolving this issue we discovered that Create/Update functions would always include this param in the vault API request, which negated the benefits of the field being Computed.In order to resolve the above issue above, and other similar ones, it is now possible to set the
VaultAPIGetterFuncby field on thecontextFuncConfig. Which means it is possible to use any of thefollowing
schema.ResourceDatamethods:GetOk(),Get(),GetOkExists()Relates #1746