raft autopilot updates #1705

fairclothjm · 2022-12-19T21:48:22Z

This PR adds a new field disable_upgrade_migration to the Raft autopilot resource. Additionally, we create a new data source for Raft autopilot state.

Output from acceptance testing:

$ TESTARGS="--run TestAccDataSourceRaftAutoPilotState" make testacc-ent
make testacc TF_ACC_ENTERPRISE=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test --run TestAccDataSourceRaftAutoPilotState -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	1.305s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	0.991s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	1.644s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	2.333s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	2.061s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	0.715s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	15.791s

fairclothjm · 2022-12-21T20:38:14Z

internal/consts/consts.go

-	FieldGroupName                = "group_name"
-	FieldExternal                 = "external"
-	FieldInternal                 = "internal"
+	FieldAPIHostname                = "api_hostname"


These have been sorted. I thought it might be ok do so since I was adding fields that were changing the indent level for all entries. However, I am beginning to doubt the value in doing this as it could make rebasing on top of this quite annoying.

Hmm that is definitely a valid point! I'm now wondering if it's better to leave these unsorted and as they were for now, and we can decide on the benefits of sorting once we have finished updating all resources/datasources to use field constants — something we are tracking for long term sustainability of this project which will add to this list a lot. Might be worth adding all the constants and then sorting them in one go. What do you think?

website/docs/d/raft_autopilot_state.html.md

vinay-gopalan

PR's looking great! Thanks for adding these 🙏🏼

website/docs/d/raft_autopilot_state.html.md

vinay-gopalan · 2022-12-22T19:37:42Z

internal/consts/consts.go

-	FieldGroupName                = "group_name"
-	FieldExternal                 = "external"
-	FieldInternal                 = "internal"
+	FieldAPIHostname                = "api_hostname"


Hmm that is definitely a valid point! I'm now wondering if it's better to leave these unsorted and as they were for now, and we can decide on the benefits of sorting once we have finished updating all resources/datasources to use field constants — something we are tracking for long term sustainability of this project which will add to this list a lot. Might be worth adding all the constants and then sorting them in one go. What do you think?

vinay-gopalan · 2022-12-22T19:38:35Z

vault/data_source_raft_autopilot_state.go

+
+// serializeFields is a map of fields that have complex structures that we will
+// serialize for convenience instead of defining the schema explicitly
+var serializeFields = map[string]string{


vinay-gopalan

LGTM!

github-actions bot added documentation size/XL labels Dec 19, 2022

fairclothjm force-pushed the vault-6022-raft-autopilot branch from 5be4f18 to 445b004 Compare December 19, 2022 21:53

fairclothjm marked this pull request as ready for review December 21, 2022 20:14

fairclothjm requested review from vinay-gopalan and benashz December 21, 2022 20:26

fairclothjm commented Dec 21, 2022

View reviewed changes

fairclothjm added 11 commits December 21, 2022 15:50

Raft autopilot updates

14c176f

add autopilot state to provider DataSourceRegistry

8cc442f

add autopilot state data source file

aabbe87

add consts and sort since we are reformatting anyway

ce6bc60

use new consts in data source file

f1e7be7

update fields and schema

ab04745

add test scaffolding

7116e0b

update data src fields and uts

12aa7b3

serialize complex data types and update tests

38c21c3

remove unnecessary sprintf

626d153

refactor hcl block

b9a572c

fairclothjm force-pushed the vault-6022-raft-autopilot branch from 156af32 to b9a572c Compare December 21, 2022 21:50

fairclothjm added 2 commits December 22, 2022 10:54

add docs for raft autopilot state data source

fa49a95

add skip raft tests env

8fd85ea

fairclothjm commented Dec 22, 2022

View reviewed changes

website/docs/d/raft_autopilot_state.html.md Outdated Show resolved Hide resolved

vinay-gopalan reviewed Dec 22, 2022

View reviewed changes

fairclothjm added 2 commits December 22, 2022 14:29

add json fields to docs and add link

2ac9af8

revert consts sorting

6e29374

vinay-gopalan approved these changes Dec 23, 2022

View reviewed changes

vinay-gopalan added this to the 3.12.0 milestone Dec 23, 2022

fairclothjm merged commit d0d7987 into main Jan 3, 2023

fairclothjm deleted the vault-6022-raft-autopilot branch January 3, 2023 21:35

DocEmmetBrown mentioned this pull request Jan 9, 2023

resource vault_raft_autopilot doesn't work anymore on non enterprise customers #1718

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

raft autopilot updates #1705

raft autopilot updates #1705

fairclothjm commented Dec 19, 2022 •

edited

Loading

fairclothjm Dec 21, 2022

vinay-gopalan Dec 22, 2022

vinay-gopalan left a comment

vinay-gopalan Dec 22, 2022

vinay-gopalan Dec 22, 2022

vinay-gopalan left a comment

raft autopilot updates #1705

raft autopilot updates #1705

Conversation

fairclothjm commented Dec 19, 2022 • edited Loading

fairclothjm Dec 21, 2022

Choose a reason for hiding this comment

vinay-gopalan Dec 22, 2022

Choose a reason for hiding this comment

vinay-gopalan left a comment

Choose a reason for hiding this comment

vinay-gopalan Dec 22, 2022

Choose a reason for hiding this comment

vinay-gopalan Dec 22, 2022

Choose a reason for hiding this comment

vinay-gopalan left a comment

Choose a reason for hiding this comment

fairclothjm commented Dec 19, 2022 •

edited

Loading