Set AWS credentials sensitive

[oacob1]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Set AWS credentials as `sensitive`

This will mark AWS Credentials as sensitive such that Terraform tools like Atlantis will not reveal new AWS credentials in github conversations. It has been raised in issue1537.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[hashicorp-cla]

All committers have signed the CLA.

[vinay-gopalan]

Hi @oacob1, thanks for opening this PR! Would you mind accepting HashiCorp's Licensing Agreement? We shall then be able to get this change merged to the codebase. Thanks! 😄

[oacob1]

Hi @oacob1, thanks for opening this PR! Would you mind accepting HashiCorp's Licensing Agreement? We shall then be able to get this change merged to the codebase. Thanks! 😄

Thank you for reviewing this @vinay-gopalan My employer Fivetran has already signed this Agreement here and Fivetran is already a partner.. Would that be good enough?

[vinay-gopalan]

Hi @oacob1, unfortunately it looks like our partner agreement doesn't cover OSS contributions so it'll be great if you could sign the CLA as well, thanks!

[oacob1]

hi @vinay-gopalan , I have signed the CLA and we should be good to go. Look forward seeing the change in next release!

[vinay-gopalan]

Looks good! Thank you for your contribution to HashiCorp!

[oacob1]

hi @vinay-gopalan, do you know when will be a new release with this fix? Thank you.

[vinay-gopalan]

Hi @oacob1, this fix has been added to the 3.12.0 release milestone and is expected to be released on December 21.