Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting deletion_allowed on a transformation #1650

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Oct 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc-ent TESTARGS='-v -test.count=1' TEST_PATH=./generated/...
make testacc TF_ACC_ENTERPRISE=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -v -test.count=1 -timeout 30m ./generated/...
?       github.com/hashicorp/terraform-provider-vault/generated [no test files]
=== RUN   TestDecodeBasic
--- PASS: TestDecodeBasic (1.04s)
=== RUN   TestDecodeBatch
--- PASS: TestDecodeBatch (0.95s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode    3.601s
=== RUN   TestEncodeBasic
--- PASS: TestEncodeBasic (1.18s)
=== RUN   TestEncodeBatch
--- PASS: TestEncodeBatch (1.01s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode    2.748s
=== RUN   TestAlphabetName
--- PASS: TestAlphabetName (1.92s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet    3.249s
=== RUN   TestRoleName
--- PASS: TestRoleName (1.94s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role        3.557s
=== RUN   TestTemplateName
--- PASS: TestTemplateName (1.90s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template    3.502s
=== RUN   TestTransformationName
--- PASS: TestTransformationName (1.87s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation      3.560s

...

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benashz benashz merged commit 7b4f5d1 into main Oct 28, 2022
@benashz benashz deleted the VAULT-9365/transform-deletion-allowed branch October 28, 2022 19:08
@benashz benashz added this to the 3.10.1 milestone Oct 28, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@benashz benashz modified the milestones: 3.10.1, 3.11.0 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants