Fix GCP auth with service account credentials #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to use the provider with SA credentials, but the authentication does not succeed because the required scope is not present in the JWT request: "https://www.googleapis.com/auth/cloud-platform" This scope is mandatory according to the documentation https://developer.hashicorp.com/vault/docs/auth/gcp#gcp-credentials The JWT sign request fails with the following error: ``` {"error":"invalid_scope","error_description":"Invalid OAuth scope or ID token audience provided."} ``` I was able to reproduce this in the TestAuthLoginGCP_Login test, but only after setting the initialized:true setting on the AuthLoginGCP.AuthLoginCommon object. I guess the test is not ran when this value is not positioned. This fixes the JWT token generation, but the provider's call to Vault is rejected because the `credentials` and `service_account` parameters are not expected by the endpoint. I added them to the `copyParamsExcluding` call and changed the expected parameters in the test. I can now run this test with valid credentials: ``` $ GOOGLE_APPLICATION_CREDENTIALS="/tmp/creds.json" TF_ACC_GOOGLE_SERVICE_ACCOUNT="[email protected]" go test -run TestAuthLoginGCP_Login PASS ok github.com/hashicorp/terraform-provider-vault/internal/provider 0.491s ```
|
|
benashz
reviewed
Oct 27, 2022
benashz
approved these changes
Oct 27, 2022
|
I know it just got merged... but any idea when it will be released?(I was just facing this same problem 😓 ) |
Sorry to hear you are having the same issue. We haven't set a date for v3.10.1 just yet. It should probably be mid next week at the earliest. |
|
thanks for the reply!, yeah next week is totally fine 👍 also thanks to @magat for the report and the fix! 🙌 |
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
|
Please pardon the delay in getting this fix out. It will go out in tomorrow's v3.11.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to use the provider with SA credentials, but the authentication does not succeed because the required scope is not present in the JWT request: "https://www.googleapis.com/auth/cloud-platform"
This scope is mandatory according to the documentation https://developer.hashicorp.com/vault/docs/auth/gcp#gcp-credentials.
The JWT sign request fails with the following error:
I was able to reproduce this in the
TestAuthLoginGCP_Logintest, but only after setting the initialized:true setting on theAuthLoginGCP.AuthLoginCommonobject. I guess the test is not ran when this value is not positioned.This fixes the JWT token generation, but the provider's call to Vault is rejected because the
credentialsandservice_accountparameters are not expected by the endpoint. I added them to thecopyParamsExcludingcall and changed the expected parameters in the test.I can now run this test with valid credentials (see below).
Community Note
Release note for CHANGELOG:
Output from acceptance testing: