-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kv-v2 write retry #1579
add kv-v2 write retry #1579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I added some initial comments/suggestions, also It be good to include some tests for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes the code better for sure. Good luck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution to HashiCorp!
Co-authored-by: Ben Ash <[email protected]>
@benashz it looks like you reverted this PR's changes to kv_secret_v2. Could you explain this? Several people have informed me that this is still broken for that resource, and looking at the final merge, that is clearly the reason. The retry/back-off is necessary here. |
any updates on this ? |
Hi @eldengates, we should the fix out in the next release 3.16.0 |
I still see this in
Any idea why? Workaround? Help is appreciated :) |
An error condition can occur if attempting to create a kv-v2 mount and write secrets to it in the same terraform run, resulting in the error:
Upgrading from non-versioned to versioned data. This backend will be unavailable for a brief period and will resume service shortly
It appears that this error is common on Vault running in a cluster, and less so when standalone.
This PR adds retry with backoff on writes to vault_kv_secret_v2 as well as vault_generic_secret resources. Followed precedent set for retry in namespaceDelete().
Closes #677
Release note for CHANGELOG:
Output from acceptance testing:
Community Note