Persist namespace to state on import #1563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a namespaced resource was being imported with the
TERRAFORM_VAULT_NAMESPACE_IMPORT
thenamespace
field was not being stored in the TF state. This would cause the imported resource to be flagged as needing recreation onterraform apply
, since a change to thenamespace
was being detected.The fix is to detect the import on any resource read, and set the imported namespace in the state. This is done by wrapping a schema's
Read
orReadContext
function on all resources.Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: