-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for kubernetes secrets engine #1515
Conversation
Documentation is still in progress. Will update this PR when they are ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, and I tested it a bit locally too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I add some initial comments/suggestions.
Co-authored-by: Ben Ash <[email protected]>
Co-authored-by: Ben Ash <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I noticed that we did not include the website docs. If you could also add/update those, that would be great!
Documentation has been added in fb6dbe4. |
- fix formatting issues - tweak the example a bit - document import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
* Adds support for kubernetes secrets engine * rename datasource read func * mark service_account_jwt as sensitive * Update vault/provider.go Co-authored-by: Ben Ash <[email protected]> * Update vault/provider.go Co-authored-by: Ben Ash <[email protected]> * add mount schema with mustAddSchema * use testCheckMountDestroyed * change token_max_ttl, token_default_ttl to integer seconds * adds documentation * remove computed from kubernetes_host, kubernetes_ca_cert * change env var in comment to be accurate * Add k8s-secrets docs to the sidebar (hashicorp#1539) - fix formatting issues - tweak the example a bit - document import * adds comment to test about needed config to run it Co-authored-by: Ben Ash <[email protected]>
Community Note
This PR adds resources and a data source for Vault Kubernetes Secrets Engine.
Closes: #1522
Release note for CHANGELOG:
Output from acceptance testing: