-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuring a DB secret's plugin_name #1320
Conversation
- ensure that all fields common to each db engine are tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Had 1 query about a test with a custom plugin name, but I'm good with the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor nits, otherwise looks good! There's a bit of redundancy between the consts, the map, and the slice that we build, but we've discussed online that you plan on refactoring those bits separately.
* Use dbEngine instances in place of constants. - replace the use of map for looking up dbEngine instances by name with a slice - factor out dbBackend* constants to dbEngine instances. * Use dbEngine names in db Schema fields. * Add some public getter methods to the dbEngine
This PR adds support for setting the
plugin_name
in thevault_database_secret_backend_connection
resource. Previously all related resources could only be provisioned using a well known default value from Vault.Community Note
Closes #1288
Release note for CHANGELOG:
Output from acceptance testing: