-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for retrying identity entity reads #1263
Conversation
vault/provider.go
Outdated
// DefaultMaxHTTPRetries is used for configuring the api.Client's MaxRetries. | ||
DefaultMaxHTTPRetries = 2 | ||
|
||
// MaxGetRetriesMultiplier is used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a multipler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we think that the default or whatever is provided by the user is good enough, then I can drop it. The docs claim the retry is used for 5xx type errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped the multiplier in d70cc26
This fix contains a mitigation that retries stale reads from a performance standby.
- compute connection timeout from configured backoff function.
- when setting ReadYourRights() on client instance that already has this feature set, the client's replicationStore is re-initialized to nil.
b6d2161
to
0f3d984
Compare
Introduced #1269 |
This fix contains a mitigation that retries stale reads from a
performance standby on new resource creation.
Output from acceptance testing: