-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contained_db field to mssql db secret backend #1259
Merged
benashz
merged 9 commits into
main
from
VAULT-4404/add-contain_db-to-db-secret-backend-conn
Dec 17, 2021
Merged
Add contained_db field to mssql db secret backend #1259
benashz
merged 9 commits into
main
from
VAULT-4404/add-contain_db-to-db-secret-backend-conn
Dec 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition the following updates were made - run mssql database secret backend connection tests against a local mssql docker container - factor out db backend types to constants - update canonical list of db backend types to include all supported types - add ability to skip db tests globally or based on the db engine type Dependency updates: - terraform-plugin-sdk/v2 to v2.10.0 - vault/api v1.3.0 - vault/sdk v0.3.1-0.20211214161113-fcc5f22bea02 - vault v1.2.1-0.20211214161113-fcc5f22bea02
benashz
force-pushed
the
VAULT-4404/add-contain_db-to-db-secret-backend-conn
branch
from
December 14, 2021 22:38
22838bc
to
042d193
Compare
benashz
changed the title
Add contain_db field to mssql db secret backend
Add contained_db field to mssql db secret backend
Dec 16, 2021
- Work around issue where the mssql plugin cannot accept a boolean value for the `contained_db` field.
vinay-gopalan
approved these changes
Dec 17, 2021
benashz
deleted the
VAULT-4404/add-contain_db-to-db-secret-backend-conn
branch
December 17, 2021 21:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition the following updates were made
mssql docker container
types
Dependency updates:
Community Note
Closes #1237
Release note for CHANGELOG:
Output from acceptance testing: