-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raft_snapshot_agent_config resource. #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Looks great! Left a few comments :)
Thanks for the review @vinay-gopalan. I fixed most of the issues you pointed out and commented on the rest. 😄 Let me know know how you want to proceed on those fronts or if you need anything else from me. |
Also @mbillow I looked into the panic, and it seems like Vault's update method for the Raft Snapshot config endpoint was erroring out and causing the panic. This should be fixed because of this merge yesterday: https://github.com/hashicorp/vault-enterprise/pull/2143/files If it still persists, please let us know by opening an issue! Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and for making the changes!
Currently the Vault provider does not support managing Raft Snapshot Agent configurations. This change introduces a resource to manage these configurations.
Community Note
Release note for CHANGELOG:
Output from acceptance testing:
The tests fail though not because the provider is doing something incorrectly, but because Vault is panicking. 😬
Upon restarting Vault, you can see that the resource is created correctly.