Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for influxdb database connection #1121

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Add support for influxdb database connection #1121

merged 7 commits into from
Nov 30, 2021

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Jul 27, 2021 •
edited by vinay-gopalan
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/database_secret_backend_connection: Add support for InfluxDB connections

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_influxdb'
--- PASS: TestAccDatabaseSecretBackendConnection_influxdb (11.77s)

@vinay-gopalan vinay-gopalan self-assigned this Nov 16, 2021
@DrFaust92
Copy link
Contributor Author

Hi, any news on this? i see this has be assigned for a while @vinay-gopalan

vinay-gopalan
vinay-gopalan approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrFaust92 sorry for the delay, and thank you so much for submitting this PR! I had just one comment about adding the username template back in since that is an available feature after 1.8, but other than that everything looks and works great! :)

Thanks for contributing!

vault/resource_database_secret_backend_connection.go Outdated Show resolved Hide resolved
@vinay-gopalan vinay-gopalan merged commit 688169a into hashicorp:main Nov 30, 2021
@vinay-gopalan vinay-gopalan mentioned this pull request Nov 30, 2021
Merged
@DrFaust92 DrFaust92 deleted the r/influxdb_db_conn branch December 2, 2021 09:54
@benashz benashz added this to the 3.1.0 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees

@vinay-gopalan vinay-gopalan

Labels
documentation feature-parity size/L
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @vinay-gopalan @benashz