-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow LDAP and JWT/OIDC Auth Backends and Consul Secret Engine resources to be Local #1115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, looking good! I know it's repetitive, but just a few comments requesting slightly more test coverage please!
@tomhjp Added the tests you requested. Let me know if there is anything else you need before merging! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those tests, I missed a bug in the previous review, but otherwise this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank! Looks great, I also just made a tiny whitespace fix to avoid an extra round trip :)
Test failures are unrelated to the changes, and instead caused by some tests that should have been skipped without the required secrets available. Fixed in #1161. |
This upgrades the LDAP and JWT/OIDC auth backend resources from the deprecated
Sys.EnableAuth
API toSys.EnableAuthWithOptions
. This also allows both of these resources to be defined as local mounts when created. I also added an option for making the Consul Secret Engine local as well and just added it to it'sMountInput
struct.Community Note
Release note for CHANGELOG:
Output from acceptance testing:
Note: It doesn't look like there are any acceptance tests for the LDAP Auth backend resource.