Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where group values not removed #1061

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

basingh
Copy link
Contributor

@basingh basingh commented May 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates
This change is similar to PR (#1054) but just for vault_identity_group.

Release note for CHANGELOG:

resource/vault_identity_group: Fix bug where metadata values are not removed if removed from file

If values are removed from the terraform file, update sees the change but sends no values to Vault. This results in no value changes on the Vault side but Terraform says it succeeded. Updated the code slightly to use HasChange.

@ghost ghost added the size/S label May 25, 2021
@jasonodonnell jasonodonnell self-requested a review May 25, 2021 20:53
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants