treat non-json values as not matching

[coryflucas]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1013

Release note for CHANGELOG:

Fix for calculated values used in vault_aws_secret_backend_role policy_document not being applied without multiple terraform apply runs.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSecretBackendRole_.*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAWSSecretBackendRole_.* -timeout 120m
?       github.com/hashicorp/terraform-provider-vault   [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/coverage      [no test files]
?       github.com/hashicorp/terraform-provider-vault/cmd/generate      [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/codegen   0.053s [no tests to run]
?       github.com/hashicorp/terraform-provider-vault/generated [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode    0.133s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode    0.148s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet    0.152s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role        0.143s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template    0.110s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation      0.091s [no tests to run]
?       github.com/hashicorp/terraform-provider-vault/schema    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-vault/util      0.100s [no tests to run]
=== RUN   TestAccAWSSecretBackendRole_basic
--- PASS: TestAccAWSSecretBackendRole_basic (5.75s)
=== RUN   TestAccAWSSecretBackendRole_import
--- PASS: TestAccAWSSecretBackendRole_import (3.26s)
=== RUN   TestAccAWSSecretBackendRole_nested
--- PASS: TestAccAWSSecretBackendRole_nested (4.53s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     13.643s

[hashicorp-cla]

All committers have signed the CLA.

[coryflucas]

Sorry for the long delay in signing the CLA, please let me know if there is anything else I can do to help with this.

[coryflucas]

Is there anything I can do to help with review on this?

[coryflucas]

@benashz @tvoran 👋 sorry to ping folks directly, but you two seem to be the most active on this recently and just hoping someone could take a look at this PR.

[benashz]

Hi @coryflucas would you mind rebasing this PR off of main. Thanks!

[coryflucas]

Hi @benashz, rebased from main and fixed the conflict, thanks!

[benashz]

LGTM!

Thank your for your contribution to HashiCorp!