SDKv2 to Framework Migration #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum
github-actions
bot
added
the
dependencies
bendbennett
reviewed
Aug 5, 2022
bendbennett
reviewed
Aug 5, 2022
bendbennett
reviewed
Aug 5, 2022
bendbennett
reviewed
Aug 5, 2022
# Conflicts: # go.sum
bendbennett
approved these changes
Sep 23, 2022
bflad
reviewed
Oct 3, 2022
bflad
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Looks good to me from a high level (I'm assuming @bendbennett has gone through all the lower level details). 🚀
Please reach out with any questions from my additional feedback, which is fairly minor in nature.
…onfigValidators method
minamijoyo
added a commit
to minamijoyo/tfmigrate
that referenced
this pull request
Nov 25, 2022
While implementing #111, we noticed that the import acceptance test for the `tfexec` package failed. #111 (comment) After investigation, I found that the time provider was significantly rewritten in v0.9.0 to migrate to the new `terraform-plugin-framework`. hashicorp/terraform-provider-time#112 As a result, the implementation of import for the `time_static` resource now implicitly sets the `triggers` attribute to an empty map `{}` instead of `null`. I’m not sure if this change was intentional or not, though; we can simply accept this change because there is no essential difference as long as the import success with no change.
minamijoyo
added a commit
to minamijoyo/tfmigrate
that referenced
this pull request
Nov 25, 2022
While implementing #111, we noticed that the import acceptance test for the `tfexec` package failed. #111 (comment) After investigation, I found that the time provider was significantly rewritten in v0.9.0 to migrate to the new `terraform-plugin-framework`. hashicorp/terraform-provider-time#112 As a result, the implementation of import for the `time_static` resource now implicitly sets the `triggers` attribute to an empty map `{}` instead of `null`. I’m not sure if this change was intentional or not, though; we can simply accept this change because there is no essential difference as long as the import success with no change.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource.TestCheckResourceAttrSethelper function