-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project level auto destroy #1550
base: main
Are you sure you want to change the base?
Conversation
91a6fb5
to
01a4069
Compare
@@ -1,5 +1,13 @@ | |||
## Unreleased | |||
|
|||
BREAKING_CHANGES: | |||
* `r/tfe_workspace`: Add attribute `inherits_project_auto_destroy` to tfe_workspace, existing workspaces with auto-destroy settings should add `inherits_project_auto_destroy: false` to tfe_workspace resource [1550](https://github.com/hashicorp/terraform-provider-tfe/pull/1550) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should do fill this out for the user the same way we do on the frontend. Basically if they have one defined in config then we should automatically set this to false
Add business org delegation to the datasource test Run go mod tidy Add interface stub Use datasource for organzation Reference data source Add missing reference Modify resource to directly reference orgname
15be161
to
54858bc
Compare
@@ -368,10 +374,12 @@ func resourceTFEWorkspaceCreate(d *schema.ResourceData, meta interface{}) error | |||
return fmt.Errorf("Error expanding auto destroy during create: %w", err) | |||
} | |||
options.AutoDestroyAt = autoDestroyAt | |||
options.InheritsProjectAutoDestroy = tfe.Bool(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last we discussed this, we don't want to set InheritsProjectAutoDestroy
within the provider, right?
Description
Add support in the tfe provider for the project level ephemeral workspace settings.
Remember to:
Testing plan
/app/<orgname>/workspaces/<workspace_name>/settings/delete
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
Project Resource
Workspace Resource
Project Data source
Workspace Data source