-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-9703 project_ids and organization_scoped to oauth client #1148
Merged
laurenolivia
merged 13 commits into
main
from
Netra2104/TF-9703-project-oauth-client-data-source-changes
Apr 22, 2024
Merged
TF-9703 project_ids and organization_scoped to oauth client #1148
laurenolivia
merged 13 commits into
main
from
Netra2104/TF-9703-project-oauth-client-data-source-changes
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netra2104
changed the title
Netra2104/tf 9703 project oauth client data source changes
TF-9703 project_ids and organization_scoped to oauth client
Nov 20, 2023
brandonc
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ 👇
hs26gill
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
laurenolivia
deleted the
Netra2104/TF-9703-project-oauth-client-data-source-changes
branch
April 22, 2024 13:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add project_ids and organization scoped to oauth client data source.
Needs to be merged after: #1144
Remember to:
Testing plan
Run the tests without skip beta flag locally.
CI test passes
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.
Documentation Output