-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent keepers from triggering an in-place update following import #385
Conversation
@bflad What is holding this PR back from being merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 Great fix, @bendbennett!
Thank you! |
<Actions> <action id="296d75eab55b9d23bd1e94dc34cea43b964c29945c12fefcb674e3c068a0a767"> <h3>Bump Terraform `random` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/random" updated from "3.6.0" to "3.6.1" in file ".terraform.lock.hcl"</p> <details> <summary>3.6.1</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-random/releases/tag/v3.6.1
BUG FIXES:

* all: Prevent `keepers` from triggering an in-place update following import ([#385](hashicorp/terraform-provider-random#385 resource/random_shuffle: Prevent inconsistent result after apply when result_count is set to 0 ([#409](hashicorp/terraform-provider-random#409 provider/random_password: Fix bug which causes panic when special, upper, lower and number/numeric are all false ([#551](hashicorp/terraform-provider-random#551 provider/random_string: Fix bug which causes panic when special, upper, lower and number/numeric are all false ([#551](https://github.com/hashicorp/terraform-provider-random/issues/551))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/118/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Version v3.6.1 of the 'random' provider changed the behavior of 'keeper' in hashicorp/terraform-provider-random#385 This upstream change caused the extra keepers = {} output in our test output since keepers are optional, and {} is same as absent for our use-cases, we're removing the empty keepers = {} from the .tf files
It doesn't seem to work in my environment:
The resource: resource "random_id" "fernet_key" {
keepers = {
name = var.secret.name
}
byte_length = 32
} |
Hi @Gitopolis 👋 I believe what you are seeing is expected behaviour. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #384