Fix upgrade v2.2.1 -> v3.4.0 forces replacement #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
reviewed
Sep 1, 2022
Comment on lines
509
to
515
| // TestAccResourcePassword_UpgradeFromVersion2_2_1 requires that you are running an amd64 Terraform binary | ||
| // if you are running this test locally on arm64 architecture otherwise you will see the following error: | ||
| // | ||
| // Error: Incompatible provider version | ||
| // | ||
| // Provider registry.terraform.io/hashicorp/random v2.2.1 does not have a | ||
| // package available for your current platform ... |
There was a problem hiding this comment.
I think we can codify this logic into the test via:
TestCase{
PreCheck: func() {
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" {
t.Skip("This test requires darwin/amd64 to download the old provider version. Setting TF_ACC_TERRAFORM_PATH to darwin/amd64 compatible Terraform binary can be used as a workaround.")
}
},
// ... other fields
}There was a problem hiding this comment.
Thanks. Have incorporated.
|
Thank you @bendbennett and @bflad! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #302
This should address #302 insofar as it fixes the issue when using the config supplied by blgm and the config supplied by alexpoto.