Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency vendoring #163

Merged
merged 1 commit into from
May 25, 2021
Merged

Remove dependency vendoring #163

merged 1 commit into from
May 25, 2021

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented May 25, 2021

Go language tooling has moved beyond the need for dependency vendoring, so we no longer recommend its use in providers.

This PR does the following:

  • delete vendor/ directory
  • remove references to this directory in Makefile and build scripts

Once this PR is merged, we will:

  • request that any PR modifying the vendor/ directory be rebased onto the main branch in order to prevent this directory being reintroduced
  • update internal build tooling to remove use of -mod=vendor from release builds.

@ghost ghost added the size/XXL label May 25, 2021
@kmoe kmoe requested a review from a team May 25, 2021 08:51
@bflad bflad self-assigned this May 25, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@kmoe kmoe merged commit 3a0035e into main May 25, 2021
@kmoe kmoe deleted the remove_vendor branch May 25, 2021 12:52
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants