-
Notifications
You must be signed in to change notification settings - Fork 79
postgresql_role: Add roles attribute. #52
postgresql_role: Add roles attribute. #52
Conversation
ee334e1
to
c8d5737
Compare
3f3a564
to
049a0f6
Compare
@cyrilgdn, Hello, tell me please, when the release is expected? |
@evgmoskalenko I'm currently looking for reviews for all my PRs, as soon as they get merged I'll try to create a new release. |
9c127f8
to
62ab8f1
Compare
5ce1039
to
b022254
Compare
9c58fd1
to
b084d49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyrilgdn I tried the code from this PR, it seems to work as advertised, the tests look good to me and I tried to make it break without success :)
Hopefully this can get merged and released really soon!
As a side node: As said previously, while testing this PR, I saw lot of connections/disconnections on the PostgreSQL server, while applying this type of change - it's not specifically due to this patch though but I guess this could be looked into.
* This allows to grant roles to the role we are managing.
b084d49
to
834fd19
Compare
Thanks @multani , I've just added the documentation for the website (which I forgot). Good remark for the connections number, it's the case for multiple resources, I'll try to enhance these behaviors in the future. |
@cyrilgdn - this feature is exactly what I was looking for today (to grant the Any idea when you’ll be able to roll a release with this feature? |
@ixalon I'll try to release a version this week |
@cyrilgdn |
@jaypz Yes sorry, didn't take the time to do it as announced . I've just asked to create the 0.4.0 release. It should be good for tomorrow (except if any troubles with the release process). |
This allows to grant roles to the role we are managing.
Example:
Fix #21
This probably conflicts with #23