Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null Provider Framework Migration #150

Merged
merged 23 commits into from
Oct 25, 2022
Merged

Null Provider Framework Migration #150

merged 23 commits into from
Oct 25, 2022

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Oct 11, 2022 •
edited
Loading

Closes #83

What?

  • Migrates Null Provider to Terraform Plugin Framework v0.14.0
  • Adds acceptance tests to compare framework and sdk versions of Null provider to ensure no differences

@SBGoods SBGoods requested a review from a team as a code owner October 11, 2022 15:06
@bflad
Copy link
Contributor

bflad commented Oct 12, 2022

I can take a look at this once #149 is in (and this is potentially rebased on top of that) so it's only showing the new differences. 👍

@SBGoods SBGoods mentioned this pull request Oct 13, 2022
Closed
1 task
bflad
bflad reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, otherwise looking good!

docs/data-sources/data_source.md Outdated Show resolved Hide resolved
examples/data-sources/null_data_source/data-source.tf Outdated Show resolved Hide resolved
internal/provider/data_source.go Outdated Show resolved Hide resolved
internal/provider/data_source_test.go Outdated Show resolved Hide resolved
internal/provider/resource.go Outdated Show resolved Hide resolved
internal/provider/resource_test.go Outdated Show resolved Hide resolved
bflad
bflad approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to merge. 🚀 Let's take the keepers attribute discussion out of band and make a decision about it before any potential release though.

internal/provider/resource.go Outdated
Optional: true,
ForceNew: true,
PlanModifiers: []tfsdk.AttributePlanModifier{
resource.RequiresReplace(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to consider something like hashicorp/terraform-provider-random#305 for this resource as well, but we can discuss and potentially handle this detail before any release.

bendbennett
bendbennett approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Agree with the out of band discussion regarding keepers.

internal/provider/data_source.go Outdated Show resolved Hide resolved
internal/provider/resource.go Outdated Show resolved Hide resolved
@SBGoods SBGoods merged commit 29beca4 into main Oct 25, 2022
@SBGoods SBGoods deleted the frameworkMigration branch October 25, 2022 14:39
@SBGoods SBGoods linked an issue Oct 26, 2022 that may be closed by this pull request
[Documentation][Web][Usability] Documentation is too wide and requires scrolling #142
Closed
1 task
@bflad bflad mentioned this pull request Mar 9, 2023
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
No milestone
3 participants
@SBGoods @bflad @bendbennett