Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Hash MySQL passwords #9

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Hash MySQL passwords #9

merged 1 commit into from
Aug 21, 2017

Conversation

apparentlymart
Copy link
Contributor

@apparentlymart apparentlymart commented Jun 27, 2017

This is a migration of @joshuaspence's work from hashicorp/terraform#13614.


Instead of storing MySQL passwords in plaintext, hash them first. This implementation is largely based on hashicorp/terraform#12128.

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should add doc changes with this as well though?

@apparentlymart
Copy link
Contributor Author

Hmm I did actually tweak the docs here but apparently that got lost in my effort to migrate this. I'll see if I still have that commit locally somewhere.

Instead of storing MySQL passwords in plaintext, hash them first. This implementation is largely based on #12128.
@apparentlymart
Copy link
Contributor Author

Found it! Looks like I pushed the wrong branch. 😖

@catsby
Copy link

catsby commented Jul 18, 2017

Is this good to merge?

@apparentlymart
Copy link
Contributor Author

Was holding for review of the docs that I forgot to push on the first pass. If that looks good, then this is ready.

Copy link

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good to merge

@apparentlymart apparentlymart merged commit bcf57cf into master Aug 21, 2017
@davidji99 davidji99 deleted the f-hash-mysql-passwords branch February 15, 2019 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants