Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Kubernetes links #626

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Updated Kubernetes links #626

merged 2 commits into from
Oct 8, 2019

Conversation

jurajseffer
Copy link
Contributor

The old ones are no longer valid.

@alexsomesan
Copy link
Member

Thanks a lot for finding and fixing this! Much appreciated.

I did a quick search for that broken URL in the codebase and it looks like it's being used in a few other places.

This is where I found it:

  • website/docs/r/ingress.html.markdown
  • website/docs/r/network_policy.html.markdown
  • website/docs/r/role_binding.html.markdown
  • website/docs/r/role.html.markdown
  • kubernetes/schema_metadata.go

Would you mind fixing it there as well?

@ghost ghost added size/L and removed size/XS labels Sep 27, 2019
@jurajseffer
Copy link
Contributor Author

@alexsomesan I've searched and replaced within the whole repo and also changed the ones that were pointing to a particular commit rather than master branch.

alexsomesan
alexsomesan approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsomesan alexsomesan merged commit c685bc5 into hashicorp:master Oct 8, 2019
@jurajseffer jurajseffer deleted the patch-1 branch October 9, 2019 09:02
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurajseffer @alexsomesan