Bugfix: host_alias to host_aliases

[minac]

Bugfix: host_alias to host_aliases

[pdecat]

There are other places in docs with the same issue, e.g.:

• https://github.com/terraform-providers/terraform-provider-kubernetes/blame/master/website/docs/r/daemonset.html.markdown#L127
• https://github.com/terraform-providers/terraform-provider-kubernetes/blame/master/website/docs/r/pod.html.markdown#L88

[pdecat]

In order to lighten the documentation maintenance burden, I believe we should remove the duplicated pod spec documentation from the kubernetes_daemon_set and kubernetes_deployment resources and just refer to the kubernetes_pod documentation, similar to what's done for kubernetes_replication_controller and kubernetes_stateful_set.

@alexsomesan WDYT?

Notes:

• in the case of kubernetes_daemon_set and kubernetes_stateful_set resources, the whole template block comes from the pod schema using the podTemplateFields() function which relies on the namespacedMetadataSchema() and podSpecFields() functions.
• in the case of kubernetes_deployment, only spec.template.spec comes directly from the pod schema using the podSpecFields() function, the spec.template.metadata comes from metadataSchema() (not namespacedMetadataSchema()).
• in the case of kubernetes_replication_controller, the whole template block comes from the pod schema using the replicationControllerTemplateFieldSpec() function which relies on the namespacedMetadataSchema() and podSpecFields() functions and implements support for legacy fields which were misplaced (see Add pod metadata to replication controller spec template #193).

Some refactoring there could help improve the situation further.

[minac]

Although I completely agree with the comments, aren't we making the scope of this simple PR way too big? Maybe a separate issue would be better to make improvements/fixes in other locations?
I know I wasted hours of my day because of this one bug and can imagine others are suffering from the same problem.

[pdecat]

Agreed. Maybe just address #413 (comment) here.
We'll take care of the rest in another issue/PR.

[pdecat]

Sorry about the trouble by the way, I'm responsible for the typo when I added the documentation that I noticed was missing from https://github.com/terraform-providers/terraform-provider-kubernetes/pull/367/files

[minac]

Hey @pdecat, we're all humans here! Let's just get this fixed using the magic of open source docs :)

[alexsomesan]

In order to lighten the documentation maintenance burden, I believe we should remove the duplicated pod spec documentation from the kubernetes_daemon_set and kubernetes_deployment resources and just refer to the kubernetes_pod documentation, similar to what's done for kubernetes_replication_controller and kubernetes_stateful_set.

@alexsomesan WDYT?

Notes:

• in the case of kubernetes_daemon_set and kubernetes_stateful_set resources, the whole template block comes from the pod schema using the podTemplateFields() function which relies on the namespacedMetadataSchema() and podSpecFields() functions.
• in the case of kubernetes_deployment, only spec.template.spec comes directly from the pod schema using the podSpecFields() function, the spec.template.metadata comes from metadataSchema() (not namespacedMetadataSchema()).
• in the case of kubernetes_replication_controller, the whole template block comes from the pod schema using the replicationControllerTemplateFieldSpec() function which relies on the namespacedMetadataSchema() and podSpecFields() functions and implements support for legacy fields which were misplaced (see Add pod metadata to replication controller spec template #193).

Some refactoring there could help improve the situation further.

Patrick, I agree. We should unify the pod templates across all workload resources and make everything re-usable. I would love that.
However the provider is still missing features and entire resources, so priority has to go to that on my side until we have decent coverage.

Happy to look at PRs though 🤓

[aareet]

Closing in favour of #869 which fixes the issue in the daemonset & pod docs as well. I retained the original commit and author from this PR.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!